Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Korean translations #30

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Update Korean translations #30

merged 2 commits into from
Nov 13, 2023

Conversation

microbit-matt-hillsdon
Copy link

No description provided.

@microbit-matt-hillsdon microbit-matt-hillsdon mentioned this pull request Nov 12, 2023
Merged
microbit-robert
microbit-robert reviewed Nov 13, 2023
View reviewed changes
Copy link

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about the resulting mix of single and double quotes, i.e., booleanIsLowerCase vs every other string. Should retain double quotes for this?
image

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit d185e3d into microbit Nov 13, 2023
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the translations branch November 13, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microbit-robert microbit-robert microbit-robert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@microbit-matt-hillsdon @microbit-robert